-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NIM storage size field update #3318
NIM storage size field update #3318
Conversation
Hi @olavtar. Thanks for your PR. I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
8d60a8b
to
ef66506
Compare
…Mi' option Signed-off-by: Olga Lavtar <[email protected]>
ef66506
to
d0ae3c0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3318 +/- ##
==========================================
+ Coverage 84.73% 84.75% +0.02%
==========================================
Files 1309 1309
Lines 29319 29329 +10
Branches 7981 7986 +5
==========================================
+ Hits 24843 24859 +16
+ Misses 4476 4470 -6
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
https://issues.redhat.com/browse/RHOAIENG-14037
Description
Added another line of helper text and removed 'Mi' option.
How Has This Been Tested?
Tested locally.
Test Impact
Tested to make sure 'Mi' does not show up as an option for NIM.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main